-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies #3183
Updated dependencies #3183
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3183 +/- ##
========================================
Coverage 89.96% 89.96%
========================================
Files 21 21
Lines 1146 1146
Branches 347 347
========================================
Hits 1031 1031
Misses 115 115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d773159
to
240dfe1
Compare
240dfe1
to
96d3625
Compare
Hey, guys, the pr looks good. May you five me permissions to merge prs... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good apart from skipped test.
but the test skip is not related with the PR itself, but rather the node version. |
@vedkribhu The skipped test case, fails for timeout The test case has been testing an edge case which passes, leaving out all the other cases when it actually fails. Since this is happening in develop as well, we can look into this in a separate PR. Let us not block this PR. |
I am attaching below screenshots of test case execution in different node versions with different timeout (All tests are run on develop branch [head commit]). Test passing in node v16.10.0 with 5ms timeout: Test failing in node v16.10.0 with 10ms timeout: Test passing in node v20.10.0 with 3ms timeout: Test failing in node v20.10.0 with 5ms timeout: The above screenshot proves that the issue is existing in develop and not introduced because of this PR. We can deep dive into the root cause of this issue and fix it in a separate PR. cc: @aman-postman |
Sourced from postman-runtime's changelog.
Sourced from postman-collection's changelog.