fix: empty chunks #566
Merged
fix: empty chunks #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brc-dd
reviewed
Jan 10, 2025
| import { defineConfig, type Options } from 'tsup' | ||
|
|
||
| export const commonOptions = { | ||
| clean: true, | ||
| clean: false, |
There was a problem hiding this comment.
this can probably be removed, it's false by default 👀
There was a problem hiding this comment.
ok (I added it explicitly to avoid reverting the flag)
|
This broke the docs generation |
|
different dts chunks are being generated because of splitting types entry in tsup. I think it's fine to leave 0 byte dist/types.js because it cannot be imported anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes:
./typessubpackage export: should export only types, there is no implementationdata-loaders/*intypesVersions: node10 types brokenclientfromtypesVersions.I'm going to check on my local Windows laptop the error with long paths in Nuxt.
We split tsup options to generate only dts for
src/types.ts(thx for the help @brc-dd)