use full hash (prysmaticlabs#7416)

potuz · Oct 2, 2020 · b589ddd · b589ddd
1 parent ba01abb
commit b589ddd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/beacon-chain/p2p/pubsub.go b/beacon-chain/p2p/pubsub.go
@@ -79,10 +79,10 @@ func (s *Service) SubscribeToTopic(topic string, opts ...pubsub.SubOpt) (*pubsub
 // Content addressable ID function.
 //
 // ETH2 spec defines the message ID as:
-//    message-id: SHA256(message.data)[:8]
+//    message-id: SHA256(message.data)
 func msgIDFunction(pmsg *pubsub_pb.Message) string {
 	h := hashutil.Hash(pmsg.Data)
-	return string(h[:8])
+	return string(h[:])
 }
 
 func setPubSubParameters() {

diff --git a/beacon-chain/p2p/pubsub_test.go b/beacon-chain/p2p/pubsub_test.go
@@ -33,6 +33,6 @@ func TestMessageIDFunction_HashesCorrectly(t *testing.T) {
 	msg := [32]byte{'J', 'U', 'N', 'K'}
 	pMsg := &pubsubpb.Message{Data: msg[:]}
 	hashedData := hashutil.Hash(pMsg.Data)
-	msgID := string(hashedData[:8])
+	msgID := string(hashedData[:])
 	assert.Equal(t, msgID, msgIDFunction(pMsg), "Got incorrect msg id")
 }