Remove unused, unsafe method

powerhome · Nov 8, 2024 · 130afed · 130afed
1 parent f5a852e
commit 130afed
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 16 deletions.
diff --git a/bearer.ignore b/bearer.ignore
@@ -1,8 +0,0 @@
-{
-  "2314bd71cca49a48fe84485b966be0b6_0": {
-    "author": "Jill Klang",
-    "comment": "Ignoring this finding for now",
-    "false_positive": false,
-    "ignored_at": "2024-11-06T20:12:15Z"
-  }
-}

diff --git a/packages/consent/docs/CHANGELOG.md b/packages/consent/docs/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## [Unreleased]
 
+- removed eval_view as a legacy, unsafe concern
+
 ## [2.0.1] - 2023-01-08
 
 - Bugfixes, minor version bumps

diff --git a/packages/consent/lib/consent/dsl.rb b/packages/consent/lib/consent/dsl.rb
@@ -14,14 +14,6 @@ def with_defaults(new_defaults, &block)
       DSL.build(@subject, @defaults.merge(new_defaults), &block)
     end
 
-    # rubocop:disable Lint/UnusedBlockArgument, Security/Eval
-    def eval_view(key, label, collection_conditions)
-      view key, label do |user|
-        eval(collection_conditions)
-      end
-    end
-    # rubocop:enable Lint/UnusedBlockArgument, Security/Eval
-
     def view(key, label, instance = nil, collection = nil, &block)
       collection ||= block
       @subject.views[key] = View.new(key, label, instance, collection)