Skip to content

Commit

Permalink
Trigger a failure
Browse files Browse the repository at this point in the history
  • Loading branch information
that-jill committed May 24, 2024
1 parent 6d0610b commit 14b31e5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/consent/lib/consent/dsl.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ def with_defaults(new_defaults, &block)
# rubocop:disable Lint/UnusedBlockArgument, Security/Eval
def eval_view(key, label, collection_conditions)
view key, label do |user|
eval(collection_conditions) #fail, friend
eval(collection_conditions)
# made to fail
eval(collection_conditions)

Check failure on line 22 in packages/consent/lib/consent/dsl.rb

View workflow job for this annotation

GitHub Actions / rule_check

[rdjson] reported by reviewdog 🐶 # Usage of dangerous 'eval' function ## Description The use of the `eval` function, which dynamically executes code represented as strings, poses a high security risk in any programming environment. This is primarily because it can be exploited to run arbitrary and potentially harmful code, making the application vulnerable to code injection attacks. ## Remediations - **Do not** use the `eval` function. Its ability to execute code that can be manipulated by an attacker introduces various injection vulnerabilities. ```ruby eval("def hello_world; puts 'Hello world!'; end") ``` - **Do** explore safer alternatives to `eval`. Use language features or libraries specifically designed for the task you're trying to accomplish with `eval`. - **Do** validate and sanitize all inputs if you must use dynamic code execution. This reduces the risk of executing malicious code. - **Do** use restricted execution environments for running code dynamically if absolutely necessary. This minimizes the potential impact of malicious code execution by isolating it from the main application environment. ## References - [OWASP: Eval Injection](https://owasp.org/www-community/attacks/Direct_Dynamic_Code_Evaluation_Eval%20Injection) - [MDN Web Docs: Never use eval!](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval#never_use_eval!) Raw Output: message:"\n# Usage of dangerous 'eval' function\n## Description\n\nThe use of the `eval` function, which dynamically executes code represented as strings, poses a high security risk in any programming environment. This is primarily because it can be exploited to run arbitrary and potentially harmful code, making the application vulnerable to code injection attacks.\n\n## Remediations\n\n- **Do not** use the `eval` function. Its ability to execute code that can be manipulated by an attacker introduces various injection vulnerabilities.\n ```ruby\n eval(\"def hello_world; puts 'Hello world!'; end\")\n ```\n- **Do** explore safer alternatives to `eval`. Use language features or libraries specifically designed for the task you're trying to accomplish with `eval`.\n- **Do** validate and sanitize all inputs if you must use dynamic code execution. This reduces the risk of executing malicious code.\n- **Do** use restricted execution environments for running code dynamically if absolutely necessary. This minimizes the potential impact of malicious code execution by isolating it from the main application environment.\n\n## References\n\n- [OWASP: Eval Injection](https://owasp.org/www-community/attacks/Direct_Dynamic_Code_Evaluation_Eval%20Injection)\n- [MDN Web Docs: Never use eval!](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval#never_use_eval!)" location:{path:"packages/consent/lib/consent/dsl.rb" range:{start:{line:22 column:9} end:{line:22 column:36}}} severity:ERROR source:{name:"Bearer" url:"https://docs.bearer.com/"} code:{value:"ruby_lang_eval_linter" url:"https://docs.bearer.com/reference/rules/ruby_lang_eval_linter"}
end
end
# rubocop:enable Lint/UnusedBlockArgument, Security/Eval
Expand Down

0 comments on commit 14b31e5

Please sign in to comment.