Skip to content

Commit

Permalink
Testing with better naming conventions
Browse files Browse the repository at this point in the history
  • Loading branch information
that-jill committed Nov 6, 2024
1 parent aebeda8 commit b39db62
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
with:
diff: true
format: rdjson
output: rd.json
output: bearer_todo.json
- name: Run reviewdog
if: always()
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
cat rd.json | reviewdog -f=rdjson -reporter=github-pr-check
cat bearer_todo.json | reviewdog -f=rdjson -reporter=github-pr-check
1 change: 1 addition & 0 deletions bearer_todo.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
4 changes: 2 additions & 2 deletions packages/consent/lib/consent/dsl.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ def with_defaults(new_defaults, &block)
# rubocop:disable Lint/UnusedBlockArgument, Security/Eval
def eval_view(key, label, collection_conditions)
view key, label do |user|
eval(collection_conditions) # Boom?
# eval(collection_conditions)
# made to fail
eval(collection_conditions) # Fail now?
eval(collection_conditions) # Triggering a failure
end
end
# rubocop:enable Lint/UnusedBlockArgument, Security/Eval
Expand Down
1 change: 0 additions & 1 deletion rd.json

This file was deleted.

0 comments on commit b39db62

Please sign in to comment.