Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock file maintenance #217

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Lock file maintenance #217

merged 6 commits into from
Jan 3, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 1, 2024

Mend Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 4am on monday" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner January 1, 2024 06:11
@renovate renovate bot added the dependencies label Jan 1, 2024
renovate-approve[bot]
renovate-approve bot previously approved these changes Jan 1, 2024
Copy link
Contributor Author

renovate bot commented Jan 3, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@xjunior
Copy link
Contributor

xjunior commented Jan 3, 2024

@benlangfeld
Licensing issues:

nio4r, 2.7.0, "MIT AND (BSD-2-Clause OR GPL-2.0-or-later)"

Looks like we approve MIT and BSD-2-Clause, but we have no decision for GPL-2.0-or-later (which, by that made up license algebra, looks optional).

@benlangfeld
Copy link
Member

@benlangfeld Licensing issues:

nio4r, 2.7.0, "MIT AND (BSD-2-Clause OR GPL-2.0-or-later)"

Looks like we approve MIT and BSD-2-Clause, but we have no decision for GPL-2.0-or-later (which, by that made up license algebra, looks optional).

I think license_finder is unable to correctly parse the AND () part. Could you test if it passes by allowing GPL-2.0-or-later in this project? If it does, we can add that to the global definition; if it does not, the bug is broader and we should instead manually approve nio4r in this project.

@xjunior
Copy link
Contributor

xjunior commented Jan 3, 2024

@benlangfeld Licensing issues:
nio4r, 2.7.0, "MIT AND (BSD-2-Clause OR GPL-2.0-or-later)"
Looks like we approve MIT and BSD-2-Clause, but we have no decision for GPL-2.0-or-later (which, by that made up license algebra, looks optional).

I think license_finder is unable to correctly parse the AND () part. Could you test if it passes by allowing GPL-2.0-or-later in this project? If it does, we can add that to the global definition; if it does not, the bug is broader and we should instead manually approve nio4r in this project.

Permitting said license did not work. I did not find any references on license_finder to parse that. I'll permit the whole formula as a license for now.

@xjunior xjunior enabled auto-merge (squash) January 3, 2024 17:20
@xjunior xjunior merged commit 87f7153 into main Jan 3, 2024
127 checks passed
@xjunior xjunior deleted the renovate/lock-file-maintenance branch January 3, 2024 17:24
@benlangfeld
Copy link
Member

Permitting said license did not work. I did not find any references on license_finder to parse that. I'll permit the whole formula as a license for now.

Might be worth opening an issue against license_finder. It should be capable of parsing that license specification and matching it to the approved list of licenses.

@xjunior
Copy link
Contributor

xjunior commented Jan 3, 2024

that-jill added a commit that referenced this pull request Jan 4, 2024
benlangfeld added a commit to powerhome/oss-guide that referenced this pull request Jan 9, 2024
Each of these licenses is permitted, but license_finder is unable to understand the expression, so we'll explicitly allow it.

See:

* powerhome/power-tools#217
* pivotal/LicenseFinder#1012
benlangfeld added a commit to powerhome/oss-guide that referenced this pull request Jan 9, 2024
Each of these licenses is permitted, but license_finder is unable to understand the expression, so we'll explicitly allow it.

See:

* powerhome/power-tools#217
* pivotal/LicenseFinder#1012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants