-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YNGJ-1058: Create Aether Observatory #297
Open
dutchess
wants to merge
14
commits into
main
Choose a base branch
from
YNGJ-1058-aether-observatory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,535
−0
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
cb95fac
YNGJ-1058: Aether Observatory 0.0.1
dutchess e10ac7c
YNGJ-1058: add to github actions and portal
dutchess 60821a8
YNGJ-1058: add to github actions and portal
dutchess 0b9818b
YNGJ-1058: Add Appraisal config
dutchess c6eedbb
YNGJ-1058: Be more explicit about teardown.
dutchess cf21e90
YNGJ-1058: pre-release gem
dutchess de5c7aa
YNGJ-1058: v0.0.1pre2
dutchess 8fb4610
YNGJ-1058: pull back zeitwerk and secure ramdom gems
dutchess b9a7736
YNGJ-1058: rubocop
dutchess 825a00a
YNGJ-1058: rubocop
dutchess b31af96
YNGJ-1058: v0.0.1pre3
dutchess def378b
YNGJ-1058: v0.0.1pre3 - tag at the same time
dutchess 9ff8dca
YNGJ-1058: Test against ruby 3.0 and 3.3
dutchess b261766
YNGJ-1058: Fix rubocop issues in gemfiles/*
dutchess File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
name: aether_observatory | ||
|
||
on: | ||
push: | ||
|
||
jobs: | ||
ruby: | ||
uses: powerhome/github-actions-workflows/.github/workflows/ruby-gem.yml@main | ||
with: | ||
package: ${{ github.workflow }} | ||
workdir: "packages/${{ github.workflow }}" | ||
gemfiles: "['gemfiles/rails_6_0.gemfile','gemfiles/rails_6_1.gemfile','gemfiles/rails_7_0.gemfile','gemfiles/rails_7_1.gemfile']" | ||
ruby: '["3.0","3.3"]' | ||
secrets: inherit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
require: | ||
- rubocop-powerhome | ||
|
||
AllCops: | ||
TargetRubyVersion: 3.0 | ||
|
||
Metrics/MethodLength: | ||
Exclude: | ||
- spec/**/*_spec.rb |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# frozen_string_literal: true | ||
|
||
appraise "rails-6-0" do | ||
gem "rails", "~> 6.0.6" | ||
end | ||
|
||
appraise "rails-6-1" do | ||
gem "rails", "~> 6.1.7" | ||
end | ||
|
||
appraise "rails-7-0" do | ||
gem "rails", "~> 7.0.8" | ||
end | ||
|
||
appraise "rails-7-1" do | ||
gem "rails", "~> 7.1.3" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# frozen_string_literal: true | ||
|
||
source "https://rubygems.org" | ||
|
||
gemspec | ||
|
||
gem "rubocop-powerhome", path: "../rubocop-powerhome" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
#!/usr/bin/env rake | ||
|
||
# frozen_string_literal: true | ||
|
||
begin | ||
require "bundler/setup" | ||
rescue LoadError | ||
puts "You must `gem install bundler` and `bundle install` to run rake tasks" | ||
end | ||
Bundler::GemHelper.install_tasks | ||
|
||
require "rspec/core/rake_task" | ||
RSpec::Core::RakeTask.new(:spec) | ||
|
||
require "rubocop/rake_task" | ||
RuboCop::RakeTask.new(:rubocop) | ||
|
||
require "yard" | ||
YARD::Rake::YardocTask.new do |t| | ||
t.files = ["lib/**/*.rb"] | ||
t.options = [ | ||
"--no-private", | ||
] | ||
end | ||
|
||
task default: %i[rubocop spec] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# frozen_string_literal: true | ||
|
||
require_relative "lib/aether_observatory/version" | ||
|
||
Gem::Specification.new do |spec| | ||
spec.name = "aether_observatory" | ||
spec.version = AetherObservatory::VERSION | ||
spec.authors = ["Terry Finn", "Justin Stanczak"] | ||
spec.email = ["[email protected]", "[email protected]"] | ||
|
||
spec.summary = "Aether Observatory" | ||
spec.description = "Aether Observatory provides an event broadcast system." | ||
spec.homepage = "https://github.com/powerhome/power-tools" | ||
spec.license = "MIT" | ||
spec.required_ruby_version = ">= 3.0" | ||
|
||
spec.metadata["rubygems_mfa_required"] = "true" | ||
spec.metadata["homepage_uri"] = spec.homepage | ||
spec.metadata["source_code_uri"] = spec.homepage | ||
spec.metadata["changelog_uri"] = "#{spec.homepage}/blob/main/packages/aether_observatory/docs/CHANGELOG.md" | ||
|
||
# Specify which files should be added to the gem when it is released. | ||
# The `git ls-files -z` loads the files in the RubyGem that have been added into git. | ||
spec.files = Dir.chdir(__dir__) do | ||
`git ls-files -z`.split("\x0").reject do |f| | ||
(f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)}) | ||
end | ||
end | ||
spec.require_paths = ["lib"] | ||
|
||
spec.add_dependency "activemodel", ">= 6.0.6.1" | ||
spec.add_dependency "activesupport", ">= 6.0.6.1" | ||
spec.add_development_dependency "appraisal", "~> 2.5.0" | ||
|
||
spec.add_development_dependency "bundler", "~> 2.1" | ||
spec.add_development_dependency "license_finder", "~> 7.0" | ||
spec.add_development_dependency "pry", ">= 0.14" | ||
spec.add_development_dependency "pry-byebug", "3.10.1" | ||
spec.add_development_dependency "rake", "~> 13.0" | ||
spec.add_development_dependency "rspec", "~> 3.0" | ||
spec.add_development_dependency "simplecov", "0.15.1" | ||
spec.add_development_dependency "yard", "0.9.21" | ||
spec.metadata["rubygems_mfa_required"] = "true" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
--- | ||
- - :inherit_from | ||
- https://raw.githubusercontent.com/powerhome/oss-guide/master/license_rules.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
## [0.0.1] - 2024-12-06 | ||
|
||
- Extracts AetherObservatory from Talkbox engine. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I see
appraisal
here....we use it to help manage our rails updates and manage the dependencies different versions of rails. If properly installed, there should be an Appraisals file that declares versions (example here].There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please add the appropriate gemfiles to the test matrix in your workflow. This library is highly dependent on the rails behavior, so I recommend you add the target rails versions to CI. As per our current usage of rails, I recommend you add rails 6.1, 7.0, 7.1 and 7.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks y'all. I meant to circle back to this, but forgot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
activemodel and activesupport are a part of rails core -- so appraising rails at a different version than the ones declared here is declaring two different versions of the same package. Since you don't directly rely on all of rails, just these two modules, you can update appraisal so it's just declaring these modules instead. We can find time tomorrow to work with you on it if needed.
We can also work with you on how we release this. We don't normally take the time to send our pre-releases to rubygems, since we can just point to the github version.