[ORA-803] Add dw-connector for Nitro-Trino intergration #311
+1,174
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=ora-dw-connector |
vdittgen
commented
Feb 25, 2025
packages/dw-connector/lib/dw-connector/adapters/trino_repository.rb
Outdated
Show resolved
Hide resolved
xjunior
reviewed
Feb 26, 2025
Co-authored-by: Garett Arrowood <[email protected]>
xjunior
reviewed
Feb 27, 2025
xjunior
previously approved these changes
Feb 27, 2025
|
@xjunior Could you please review it again? |
There was a problem hiding this comment.
PR Overview
A new Ruby gem ("dw_connector") is being introduced to standardize querying across data warehouse engines with built‐in support for Trino and an extensible adapter system.
- Added build, test, lint, and release tasks in the Rakefile
- Implemented the Trino adapter and updated the RepositoryFactory to register and create adapters
- Included comprehensive tests and documentation updates for the connector
Reviewed Changes
| File | Description |
|---|---|
| packages/dw_connector/Rakefile | Added tasks for spec, rubocop, and gem release procedures |
| packages/dw_connector/Gemfile | Defined development and test dependencies for the connector |
| packages/dw_connector/spec/** | Added tests for repository functions and adapter behavior |
| packages/dw_connector/docs/** | Updated documentation and contributing guidelines |
| packages/dw_connector/lib/dw_connector/adapters/trino_repository.rb | Introduced the Trino adapter with query execution and pagination handling |
| packages/dw_connector/lib/dw_connector/repository_factory.rb | Defined dynamic adapter registration and instantiation |
| packages/dw_connector/lib/dw_connector/data_warehouse_repository.rb | Added default transformation options and methods for query response transformation |
| packages/dw_connector/lib/dw_connector.rb | Condensed setup by requiring necessary files and registering the default adapter |
| packages/dw_connector/lib/dw_connector/version.rb | Set the gem version |
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runway story
A flexible Ruby data warehouse connector library that provides a standardized interface for querying different data warehouse engines. Currently supports Trino with an extensible architecture for adding other engines.
Features