Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently duplicate column names in a query result are overwritten with only the last column being the one return. This causes issues with join queries (a simple case is where multiple
id
columns are returned) and is more apparent when doing joins with one of the ORM drivers (Kysely/Drizzle). This issue is covered by the newly added tests.This PR introduces
executeRaw
which processes the sqlite3 results differently and allows the ORM driver to correctly map the resulting columns.An existing approach for Drizzle-orm packages can be seen here:
https://github.com/drizzle-team/drizzle-orm/blob/main/drizzle-orm/src/op-sqlite/session.ts#L165
https://github.com/drizzle-team/drizzle-orm/blob/main/drizzle-orm/src/better-sqlite3/session.ts#L156
To be done
executeRaw
memberexecuteRaw
implementationWorkaround
For Drizzle users using joins the following example shows how to side-step the problem in the interim: