Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream PR #2184 with fix for LogViewer rendering issue #1

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

mturley
Copy link

@mturley mturley commented Dec 5, 2023

Description

Pushes commits to opendatahub-io#2184 to work around a LogViewer bug (patternfly/react-log-viewer#55) exposed by that PR

1Cw1TgiHu1

cc @ppadti

How Has This Been Tested?

With the default tab changed back to Input / Output, you can see that switching to the Logs tab now renders the log contents correctly. Before, the log contents would not be visible unless the Logs tab was the default tab.

Test Impact

Just helping out with the existing PR, I'm new to the project and haven't familiarized myself with the tests yet

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti ppadti merged commit 9c0581a into ppadti:issue-1738 Dec 6, 2023
3 checks passed
@mturley mturley deleted the issue-1738-logs-tab-render-fix branch December 6, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants