Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the brew formula for every new release #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

carmal891
Copy link

Changes made to address issue ppc64le-cloud/pvsadm#667 efficiently using the action https://github.com/dawidd6/action-homebrew-bump-formula?tab=readme-ov-file.

  • Splits the existing formula to multiple files based on OS platform. Maintains a parent formula that orchestrates brew installation based on OS platform at the time of execution

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carmal891

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot
Copy link

Welcome @carmal891! It looks like this is your first PR to ppc64le-cloud/homebrew-pvsadm 🎉

@carmal891
Copy link
Author

carmal891 commented Sep 24, 2024

@mkumatag @kishen-v Upon addressing the Homebrew linting issues, I've learned that Homebrew formula files must include a URL and SHA256 checksum. This means the current approach of maintaining a parent formula that routes to child formulas based on the OS platform is no longer a feasible logic. I will explore alternative solutions moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants