Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Updates: Latest pvsadm Version, Updated Repository Commit ID, and Enhancements #456

Merged

Conversation

Poorna-Gottimukkula1
Copy link
Contributor

Script Updates samples/convert-upload-images-powervs/convert-upload-images-powervs:-

  • The latest available pvsadm version has been updated
  • The latest commit ID for the ocp-power-automation/openshift-install-power repository has been added to the source command.
  • The functions download_image and copy_image_to_remote have been disabled in order to avoid downloading the RHEL image locally and copying it to the remote location. This change was made because RHEL provides dynamic download links that are valid for 240 minutes before they expire.
  • The script now includes the --skip-os-password option for skipping the process of changing the root user password

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2023
@mkumatag
Copy link
Member

/cc sudeeshjohn

@mkumatag
Copy link
Member

/assign sudeeshjohn

Copy link
Contributor

@sudeeshjohn sudeeshjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bkhadars
Copy link
Contributor

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bkhadars, mkumatag, Poorna-Gottimukkula1, sudeeshjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 765a21d into ppc64le-cloud:main Jul 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants