Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate bluemix-go and clean-up code. #612

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Deprecate bluemix-go and clean-up code. #612

merged 1 commit into from
Sep 11, 2024

Conversation

kishen-v
Copy link
Contributor

@kishen-v kishen-v commented May 13, 2024 •
edited
Loading

Fixes: #496, #609.

Note: The changes are done, a quick round of testing across all sub-commands is complete, barring test.cloud.ibm.com

get:
  • cloud-connections List the existing cloud connections in the account
    Works with workspace ID or workspace name.
  • events Get Powervs events
    Works with workspace ID or workspace name.
  • per-availability List regions that support PER
    Works with workspace ID or workspace name.
  • ports Get PowerVS network ports 

    Works with workspace ID or workspace name/ network ID and network name

delete:
  • port Delete PowerVS network port
    Works with workspace ID - network ID and network name
create:
  • port Create PowerVS network port
    Works with workspace ID - network ID and network name
purge:
  • images Purge the powervs images
  • keys Delete PowerVS ssh key/keys
  • networks Purge the powervs networks
  • vms Purge the powervs vms
  • volumes Purge the powervs volumes
dhcpserver
  • create Create DHCP Server
  • delete Delete DHCP Server
  • get Get DHCP Server
  • list Get PowerVS DHCP servers
image
  • import Import the image into PowerVS instances
    Works with public/private buckets, with HMAC/Without HMAC keys.
  • sync Sync images between IBM COS buckets
  • upload Upload the image to the IBM COS

What wasn't tested:
Testing in the test environment - https://test.cloud.ibm.com/login

Additional tweaks/changes that are a part of this PR:

pvsadm image upload - Iterate through the available set of keys until a credential with a binding HMAC key is found, rather than exiting out.

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 13, 2024
@kishen-v kishen-v marked this pull request as draft May 14, 2024 05:03
@ppc64le-cloud-bot ppc64le-cloud-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 16, 2024
@kishen-v kishen-v changed the title [WIP] Deprecate bluemix-go and clean-up code. Deprecate bluemix-go and clean-up code. May 16, 2024
@kishen-v kishen-v marked this pull request as ready for review May 16, 2024 16:46
@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@kishen-v
Copy link
Contributor Author

cc: @Karthik-K-N.

Karthik-K-N
Karthik-K-N reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review, Will take a look again later.

cmd/get/cloudconnections/cloudconnections.go Outdated Show resolved Hide resolved
cmd/get/cloudconnections/cloudconnections.go Outdated Show resolved Hide resolved
cmd/image/import/import.go Outdated Show resolved Hide resolved
cmd/image/import/import.go Outdated Show resolved Hide resolved
cmd/image/import/import.go Outdated Show resolved Hide resolved
cmd/image/import/import.go Outdated Show resolved Hide resolved
cmd/image/upload/upload.go Outdated Show resolved Hide resolved
pkg/client/client.go Outdated Show resolved Hide resolved
@mkumatag
Copy link
Member

mkumatag commented Jun 7, 2024

@kishen-v it will be great if you can divide this PR into two, one for deprecating and another for cleanup..

@kishen-v kishen-v changed the title Deprecate bluemix-go and clean-up code. [WIP] Deprecate bluemix-go and clean-up code. Jun 13, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
@kishen-v
Copy link
Contributor Author

kishen-v commented Jun 13, 2024 •
edited
Loading

Working on splitting the PR to contain smaller changes.
/hold

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2024
@kishen-v kishen-v mentioned this pull request Jun 13, 2024
Merged
@mkumatag
Copy link
Member

mkumatag commented Aug 1, 2024

@kishen-v can you please rebase this PR?

@ppc64le-cloud-bot ppc64le-cloud-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 11, 2024
@kishen-v kishen-v changed the title [WIP] Deprecate bluemix-go and clean-up code. Deprecate bluemix-go and clean-up code. Aug 11, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2024
@kishen-v
Copy link
Contributor Author

/hold cancel

@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2024
kishen-v
kishen-v commented Aug 22, 2024
View reviewed changes
cmd/root.go Outdated Show resolved Hide resolved
kishen-v
kishen-v commented Aug 22, 2024
View reviewed changes
cmd/image/upload/upload.go Outdated Show resolved Hide resolved
mkumatag
mkumatag requested changes Aug 29, 2024
View reviewed changes
pkg/client/pvmclient.go Outdated Show resolved Hide resolved
pkg/client/pvmclient.go Outdated Show resolved Hide resolved
pkg/client/s3client.go Outdated Show resolved Hide resolved
cmd/image/sync/sync.go Outdated Show resolved Hide resolved
test/e2e/sync/sync.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
pkg/client/client.go Outdated Show resolved Hide resolved
pkg/client/client.go Outdated Show resolved Hide resolved
pkg/client/client.go Show resolved Hide resolved
pkg/client/client.go Outdated Show resolved Hide resolved
@mkumatag
Copy link
Member

mkumatag commented Sep 3, 2024

@kishen-v lets fix the remaining comments and merge the code

@ppc64le-cloud-bot ppc64le-cloud-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 3, 2024
@kishen-v kishen-v force-pushed the deprecate-bluemix branch 2 times, most recently from 90965d9 to ead5d70 Compare September 5, 2024 16:38
@kishen-v kishen-v mentioned this pull request Sep 5, 2024
Closed
@kishen-v kishen-v force-pushed the deprecate-bluemix branch 2 times, most recently from 0e995f1 to cba81f4 Compare September 10, 2024 11:49
mkumatag
mkumatag requested changes Sep 10, 2024
View reviewed changes
pkg/.DS_Store Outdated Show resolved Hide resolved
cmd/image/import/import.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
pkg/client/environments.go Outdated Show resolved Hide resolved
mkumatag
mkumatag approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 3b810d2 into ppc64le-cloud:main Sep 11, 2024
5 checks passed
@mkumatag mkumatag mentioned this pull request Sep 11, 2024
Merged
@kishen-v kishen-v mentioned this pull request Sep 12, 2024
Closed
@kishen-v kishen-v deleted the deprecate-bluemix branch September 13, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharaneeshvrd dharaneeshvrd dharaneeshvrd left review comments

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

@mkumatag mkumatag mkumatag approved these changes

@Rajalakshmi-Girish Rajalakshmi-Girish Awaiting requested review from Rajalakshmi-Girish

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency - https://github.com/IBM-Cloud/bluemix-go
5 participants
@kishen-v @mkumatag @ppc64le-cloud-bot @dharaneeshvrd @Karthik-K-N