Code cleanup #659
Merged
Code cleanup #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppc64le-cloud-bot
added
the
size/L
kishen-v
commented
Sep 11, 2024
| return nil, errors.ToError(err) | ||
| } | ||
| return resp.Payload, nil | ||
| return c.client.GetAll() |
There was a problem hiding this comment.
A definition for GetAll() exists in power-go-client. The same has been re-used as the functionality is indifferent from the current implementation.
params := p_cloud_volumes.NewPcloudCloudinstancesVolumesGetallParams().
WithContext(f.ctx).WithTimeout(helpers.PIGetTimeOut).
WithCloudInstanceID(f.cloudInstanceID)
resp, err := f.session.Power.PCloudVolumes.PcloudCloudinstancesVolumesGetall(params, f.session.AuthInfo(f.cloudInstanceID))
if err != nil {
return nil, ibmpisession.SDKFailWithAPIError(err, fmt.Errorf("failed to Get all Volumes for Cloud Instance %s: %w", f.cloudInstanceID, err))
}
if resp == nil || resp.Payload == nil {
return nil, fmt.Errorf("failed to Get all Volumes for Cloud Instance %s", f.cloudInstanceID)
}
return resp.Payload, nil
kishen-v
commented
Sep 11, 2024
| @@ -27,13 +27,6 @@ type ResourceControllerV2 struct { | |||
| ResourceControllerV2 *rcv2.ResourceControllerV2 | |||
| } | |||
|
|
|||
| func NewResourceControllerV2(r *rcv2.ResourceControllerV2Options) (*ResourceControllerV2, error) { | |||
kishen-v
commented
Sep 11, 2024
| @@ -52,22 +47,14 @@ func (c *Client) GetAllPublic() (*models.Networks, error) { | |||
| } | |||
|
|
|||
| func (c *Client) GetAll() (*models.Networks, error) { | |||
| params := p_cloud_networks.NewPcloudNetworksGetallParamsWithTimeout(pkg.TIMEOUT).WithCloudInstanceID(c.instanceID) | |||
There was a problem hiding this comment.
An existing definition exists in power-go-client. The definition is indifferent from the one in the imported package.
func (f *IBMPINetworkClient) GetAll() (*models.Networks, error) {
params := p_cloud_networks.NewPcloudNetworksGetallParams().
WithContext(f.ctx).WithTimeout(helpers.PIGetTimeOut).
WithCloudInstanceID(f.cloudInstanceID)
resp, err := f.session.Power.PCloudNetworks.PcloudNetworksGetall(params, f.session.AuthInfo(f.cloudInstanceID))
if err != nil {
return nil, ibmpisession.SDKFailWithAPIError(err, fmt.Errorf("failed to Get Network for cloud instance %s with error %w", f.cloudInstanceID, err))
}
if resp == nil || resp.Payload == nil {
return nil, fmt.Errorf("failed to Get Network for cloud instance %s", f.cloudInstanceID)
}
return resp.Payload, nil
}
mkumatag
requested changes
Sep 11, 2024
|
/hold for #660 |
ppc64le-cloud-bot
added
the
do-not-merge/hold
kishen-v
changed the title
workspace name and cleanup code.
kishen-v
force-pushed
the
cleanup-3
branch
2 times, most recently
from
335bab8
to
a6d940c
Compare
|
/unhold |
ppc64le-cloud-bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishen-v, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes definitions to reuse code, removes unused definitions and redundant declarations.