Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint and keywords #288

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Pylint and keywords #288

merged 4 commits into from
Sep 19, 2023

Conversation

ppfeufer
Copy link
Owner

@ppfeufer ppfeufer commented Sep 19, 2023

Description

Fixed

  • Pylint issues

Changed

  • Use keyword arguments wherever possible

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

@ppfeufer ppfeufer marked this pull request as ready for review September 19, 2023 18:03
Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some food for thought. View full project report here.

afat/views/fatlinks.py Outdated Show resolved Hide resolved
afat/views/fatlinks.py Outdated Show resolved Hide resolved
afat/models.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #288 (0f743f9) into development (ed37e2e) will increase coverage by 0.03%.
Report is 5 commits behind head on development.
The diff coverage is 60.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #288      +/-   ##
===============================================
+ Coverage        68.54%   68.57%   +0.03%     
===============================================
  Files               24       24              
  Lines             1246     1247       +1     
  Branches           151      151              
===============================================
+ Hits               854      855       +1     
  Misses             372      372              
  Partials            20       20              
Files Changed Coverage Δ
afat/admin.py 56.48% <0.00%> (ø)
afat/forms.py 100.00% <ø> (ø)
afat/helper/fatlinks.py 100.00% <ø> (ø)
afat/providers.py 100.00% <ø> (ø)
afat/templatetags/filters.py 100.00% <ø> (ø)
afat/tests/fixtures/utils.py 100.00% <ø> (ø)
afat/urls.py 100.00% <ø> (ø)
afat/tasks.py 35.42% <12.50%> (ø)
afat/utils.py 55.08% <28.58%> (ø)
afat/views/fatlinks.py 32.08% <36.21%> (ø)
... and 14 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10231a4...0f743f9. Read the comment docs.

ppfeufer and others added 2 commits September 19, 2023 20:07
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
@ppfeufer ppfeufer merged commit 5ed593c into development Sep 19, 2023
79 of 80 checks passed
@ppfeufer ppfeufer deleted the pylint-and-keywords branch September 19, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant