Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The big rename #291

Merged
merged 9 commits into from
Sep 22, 2023
Merged

The big rename #291

merged 9 commits into from
Sep 22, 2023

Conversation

ppfeufer
Copy link
Owner

Description

Renamed the models to give them better and more sane names

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

@ppfeufer ppfeufer marked this pull request as ready for review September 22, 2023 11:29
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #291 (4e809cf) into development (4a6086d) will decrease coverage by 0.19%.
The diff coverage is 66.67%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #291      +/-   ##
===============================================
- Coverage        68.57%   68.37%   -0.19%     
===============================================
  Files               24       24              
  Lines             1247     1236      -11     
  Branches           151      151              
===============================================
- Hits               855      845      -10     
+ Misses             372      371       -1     
  Partials            20       20              
Files Changed Coverage Δ
afat/views/fatlinks.py 32.08% <18.19%> (ø)
afat/tasks.py 35.42% <50.00%> (ø)
afat/helper/views.py 92.14% <75.00%> (ø)
afat/managers.py 92.31% <85.72%> (ø)
afat/models.py 92.31% <90.00%> (+0.14%) ⬆️
afat/admin.py 56.48% <100.00%> (ø)
afat/forms.py 100.00% <100.00%> (ø)
afat/helper/fatlinks.py 100.00% <100.00%> (ø)
afat/utils.py 55.08% <100.00%> (ø)
afat/views/dashboard.py 78.13% <100.00%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6086d...4e809cf. Read the comment docs.

@ppfeufer
Copy link
Owner Author

The overall coverage decrease was to be expected as we removed some code.

@ppfeufer ppfeufer merged commit 813c79f into development Sep 22, 2023
78 of 80 checks passed
@ppfeufer ppfeufer deleted the the-big-rename branch September 22, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant