Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Optional Doctrine Dropdown to FAT Creation Forms #363

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

ppfeufer
Copy link
Owner

@ppfeufer ppfeufer commented Nov 7, 2024

Description

Added

  • Optional Doctrine dropdown field to FAT creation forms

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 87.69231% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.18%. Comparing base (5048bbb) to head (e88025b).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
afat/helper/fatlinks.py 60.00% 3 Missing and 1 partial ⚠️
afat/models.py 92.00% 2 Missing ⚠️
afat/views/fatlinks.py 33.34% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   69.51%   70.18%   +0.67%     
==========================================
  Files          28       28              
  Lines        1233     1294      +61     
  Branches      113      114       +1     
==========================================
+ Hits          857      908      +51     
- Misses        362      369       +7     
- Partials       14       17       +3     
Files with missing lines Coverage Δ
afat/admin.py 60.64% <100.00%> (+4.17%) ⬆️
afat/app_settings.py 100.00% <100.00%> (ø)
afat/forms.py 100.00% <100.00%> (ø)
afat/helper/views.py 93.21% <ø> (-1.98%) ⬇️
afat/models.py 92.25% <92.00%> (-0.05%) ⬇️
afat/views/fatlinks.py 32.09% <33.34%> (-0.20%) ⬇️
afat/helper/fatlinks.py 80.96% <60.00%> (-19.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5048bbb...e88025b. Read the comment docs.

@ppfeufer ppfeufer marked this pull request as ready for review November 8, 2024 16:33
Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth considering. View full project report here.

afat/models.py Outdated Show resolved Hide resolved
afat/models.py Outdated Show resolved Hide resolved
@ppfeufer ppfeufer merged commit 8ab175d into master Nov 8, 2024
44 checks passed
@ppfeufer ppfeufer deleted the add-optional-doctrine-field branch November 8, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant