fix: co-locate SKILL.md JSON output with the --format flag - #3
Merged
Conversation
ANCC's skill-md-flags and skill-md-json-output checks want the JSON output schema documented under the same command section as the --format flag that produces it. The prior rewrite put --format under aws/gcp but the JSON block under the flagless version command, and never spelled out the literal --format json value. Move the schema under aws (gcp references it), and make the json value explicit.
Verified against ancc's own internal/skillmd/parser.go and internal/validator/checks.go source: reBoldLabel requires the colon INSIDE the ** markers (my prior "**JSON output** (...):" put it outside, so the subsection was never recognized), and checkFlags only inspects each flag's own backtick span (a "--format string" flag description mentioning --format json in prose doesn't count). Use a literal --format json flag entry and a bare **JSON output:** label, simulated against the actual regexes before pushing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANCC's skill-md-flags and skill-md-json-output checks want the JSON output schema documented under the same command section as the --format flag that produces it. The prior rewrite put --format under aws/gcp but the JSON block under the flagless version command, and never spelled out the literal --format json value. Move the schema under aws (gcp references it), and make the json value explicit.