Wo 18/iops idle - #7
Merged
Merged
Conversation
WO-18: IDLE_INSTANCE required TotalConns == 0, which never fires with connection pools. Broaden the check to also flag instances with low total IOPS (read + write) regardless of pooled connection count. A pooled-connection idle finding is graded needs-review with a countersignal naming the connection count, since a warm pool does not prove the app is permanently dead. WO-19: DatabaseConnections was fetched with Sum and accumulated across all daily datapoints, producing 134305 instead of the actual 6.7 average connections. Changed to Average so the countersignal shows sensible numbers. Validated live: 3 previously-invisible dead instances now surfaced (loyalty-prod, marketplace-prod, task-center-prod), each at ~$25/mo.
…ents Self-review caught real production database names (loyalty-prod, marketplace-prod, etc.) leaking into public-repo test code and comments. Replaced with generic descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.