Skip to content

Conversation

Givikap120
Copy link
Contributor

It changes score input field to text so you can enter scores from legacy db

Copy link
Member

@stanriders stanriders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very dirty implementation. You're lacking any kind of validation now, as well as making score id fields not actually contain score id

How useful is this? Legacy score links should not be exposed anywhere anymore I'm pretty sure, why would we need to support them?

@stanriders stanriders added the perfcalc-gui PerformanceCalculatorGUI label Jun 28, 2025
@Givikap120
Copy link
Contributor Author

This is a very dirty implementation. You're lacking any kind of validation now, as well as making score id fields not actually contain score id

How useful is this? Legacy score links should not be exposed anywhere anymore I'm pretty sure, why would we need to support them?

If you have legacy link (happens when you take score from lb without lazer mode) - you need to go through painful process of extracting new id from json response.
With this - you can just use legacy id, saving time.

@wulpine
Copy link
Member

wulpine commented Jun 29, 2025

If you have legacy link (happens when you take score from lb without lazer mode)

are you by any chance using osuplus? It replaces new links with the legacy ones

you need to go through painful process of extracting new id from json response

might help you save some time if the above is true—the "Download Replay" button always has the new score ID

@stanriders
Copy link
Member

This is a very dirty implementation. You're lacking any kind of validation now, as well as making score id fields not actually contain score id
How useful is this? Legacy score links should not be exposed anywhere anymore I'm pretty sure, why would we need to support them?

If you have legacy link (happens when you take score from lb without lazer mode) - you need to go through painful process of extracting new id from json response. With this - you can just use legacy id, saving time.

I just checked, both lazer and non-lazer modes use new links

@Givikap120
Copy link
Contributor Author

Added the validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perfcalc-gui PerformanceCalculatorGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants