Add Alt+MouseWheel as a global volume adjust binding
#31281
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This offers the defaults users have come to expect while also allowing rebinding (if they don't want it) and better compatibility with other global actions (since this is no longer implemented using `OnScroll` event flow). Addresses part of ppy#31267.
|
relevant test failures, same as #31278 this breaks alt-scroll for timeline zoom in editor. maybe fixable by moving alt-scroll for timeline zoom to a editor hotkey, although that's sorta icky because the whole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This offers the defaults users have come to expect while also allowing rebinding (if they don't want it) and better compatibility with other global actions (since this is no longer implemented using
OnScrollevent flow).Addresses part of #31267.