Do not force miss slider with strict tracking active if tracking is lost before head was judged #31304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do any of the test cases include behavior around slider ticks? |
|
Why would ticks be relevant here in any capacity? |
|
Nevermind, I thought that ticks were stricter but after testing their not. I was wondering if a test case should be made for missing both the head and a tick, but it seems that would just count as missing the body/tail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29371.
#26053 is a previous related fix that should probably have included this change but did not go far enough.
An interesting part of this is the part that pertains to what should happen when the slider head is not hit (see test cases added in 033fe3f). I've opted to go with the lenient choice, which is to let the user continue to pick up tracking the slider even after the head was missed (but if tracking is lost at any point after that, the tail will miss as usual).