Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slider repeats not properly respecting "show hit markers" setting #31354

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Dec 30, 2024

Closes #31286.

Before:

2024-12-30.13-54-28.mp4

After:

2024-12-30.13-55-46.mp4

Gonna be honest, didn't do cross-checking against stable on this one, just went off copy-paste and the gifs provided by the issue thread author.

Curious on thoughts about how the instant arrow fade looks on non-classic skins. On argon it's probably fine, but it does look a little off on triangles...

Closes ppy#31286.

Curious on thoughts about how the instant arrow fade looks on
non-classic skins. On argon it's probably fine, but it does look a
little off on triangles...
@peppy
Copy link
Member

peppy commented Dec 30, 2024

Hmm, this is somewhat related to a high priority point on my own "must fix" list – the slider end hit markers don't stay for long enough. In stable:

2024-12-30.22.07.12.mp4

Didn't notice that repeats were also affected..

Am also not sure about the repeat arrow instafade, does seem a bit weird. Will do some usability testing.

@peppy
Copy link
Member

peppy commented Jan 2, 2025

I'm hesitant about the immediate arrow hiding, but let's leave it for now.

@peppy peppy merged commit 2d4a3aa into ppy:master Jan 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hit markers don't work on reverse sliders
2 participants