Add types for svelte-filepond
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #13 |
|
Thanks Nick going to check this out as soon as possible. |
|
@rikschennink : is this PR ok for you ? 😃 |
|
@pierre-H Haven't gotten around to it yet. |
| * Comma-separated list of accepted file types | ||
| * @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#attr-accept | ||
| **/ | ||
| acceptedFileTypes?: string; |
There was a problem hiding this comment.
This conflicts with the filepond-plugin-file-validate-type plugin, it says it should accept a string[] but this says it should be a string. The plugin already has TypeScript support so this line should be removed.
|
I hope this could be merged soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
svelteto^3.31because theSvelteComponentTypedrequired to do this was added in that release.rollup-plugin-svelteto v6.1.1, which fixes a broken require that was throwing when running the buildrollup-plugin-sveltebut it requires upgrading rollup to v2, a new major.dist/folder of this package (this could possibly be removed asnpm run buildis also theprepublishaction?)