Fix sign conversion issues#7
Open
define-private-public wants to merge 1 commit intoprakhar1989:masterfrom
define-private-public:patch-1
Open
Fix sign conversion issues#7define-private-public wants to merge 1 commit intoprakhar1989:masterfrom define-private-public:patch-1
define-private-public wants to merge 1 commit intoprakhar1989:masterfrom
define-private-public:patch-1
Conversation
I was including this on a project of mine where I had `-Wall -Wextra -pedantic` turned on to clean up any extra warnings. I caught about 4 of them in relation to implicit sign and type conversions. Adding some `static_cast<>` calls and changing a data type resolved all of the warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was including this on a project of mine where I had
-Wall -Wextra -pedanticturned on to clean up any extra warnings. I caught about 4 of them in relation to implicit sign and type conversions. Adding somestatic_cast<>calls and changing a data type resolved all of the warnings.For reference, here are the warnings: