Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing code fold styles to types #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mabeyj
Copy link

@mabeyj mabeyj commented Dec 15, 2020

  • Add codeFold and codeFoldContent values to ReactDiffViewerStylesOverride. This fixes a type error that occurs when attempting to override these styles:

    Type '{ variables: { light: { removedBackground: string; addedBackground: string; }; }; codeFold: { background: string; borderTop: string; borderBottom: string; textAlign: string; }; codeFoldContent: { ...; }; ... 7 more ...; content: { ...; }; }' is not assignable to type 'ReactDiffViewerStylesOverride'.
    Object literal may only specify known properties, and 'codeFold' does not exist in type 'ReactDiffViewerStylesOverride'.

  • Add codeFoldContent to ReactDiffViewerStyles. For completeness, since all other styles are specified here.

  • Add codeFoldContent to README.

  • Add a test for rendering the component with all available styles. This will fail if there are any type errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant