-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build((react)): Add support for React 17-18 #163
base: master
Are you sure you want to change the base?
Conversation
is this project still supported ? |
Interested in this PR |
Can someone maybe fork this and create another deployment on npm, since this does not seem to be actively maintained anymore? Also, react-dom should also be bumped in the peer-dependecies. |
@@ -79,7 +79,7 @@ | |||
"webpack-dev-server": "^3.1.9" | |||
}, | |||
"peerDependencies": { | |||
"react": "^15.3.0 || ^16.0.0", | |||
"react": "^15.3.0 || ^16.0.0 || ^17.0.0 || ^18.0.0", | |||
"react-dom": "^15.3.0 || ^16.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also bump react-dom?
There are many people who have already forked this and published it to npm, for what it's worth. |
can you give me those repositories that are in npm? i work for a company that i can download from npm but i cant copy from GitHub so this is important |
Ive been using this fork to get around this issue - https://www.npmjs.com/package/react-diff-viewer-continued |
With npm version > 7 you can't use the package without
--legacy-peer-deps