Semantically, lda should be K for a row major matrix with shape (MxK), similarly, ldc should be M for a column major matrix with shape (MxN)#14
Open
OuyeXie wants to merge 1 commit intopranjalssh:mainfrom
Conversation
…, similarly, ldc should be M for a column major matrix with shape (MxN)
|
Also found this bug. Wonder how it was working before? From my testing, seems to be fine for square matrices but for rectangle shapes, cublas complains at runtime: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected leading dimensions for A and C. Details as follows:
Tested with M=256, N=128, K=64, locally.