-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a script to start the startup programs like other DE #1749
Open
ALEX5402
wants to merge
1
commit into
prasanthrangan:main
Choose a base branch
from
ALEX5402:contribute
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#!/usr/bin/env bash | ||
|
||
# Directory containing the .desktop files | ||
AUTOSTART_DIR="$HOME/.config/autostart/" | ||
for desktop_file in "$AUTOSTART_DIR"*.desktop; do | ||
if [ -f "$desktop_file" ]; then | ||
exec_command=$(grep -E '^Exec=' "$desktop_file" | sed 's/^Exec=//') | ||
if [ -n "$exec_command" ]; then | ||
$exec_command & | ||
fi | ||
fi | ||
done |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ALEX5402,
This is good, but as I read through the discussion, both parties have good thoughts about this.
You can move this line to ./userprefs.t2 (
hyprdots/Configs/.config/hypr/userprefs.t2
Line 25 in 4c16d55
I encourage you to make this optional as honestly this will become a burden for maintaining the repo, as by default we don't know what packages/services are run on startup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default it gonna run those packages only which you enabled on startup from inside the app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain more about the script? What I understand of the script is it will extract the "Exec=" part, which is the command to launch an app, nothing fancy.
What you are saying is the script can pinpoint which users enabled the startup "from inside the app" ?
Or you are saying that
$AUTOSTART_DIR
is respected by most apps, and enabling it to run at the startup "from inside the app". Which I assumed that the application adds the .desktop file entry to the $AUTOSTART_DIR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
then should i change that with
$AUTOSTART_DIR
?