Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opacity for some commonly used apps #1958

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zeerayne
Copy link
Contributor

Pull Request

Description

This adds opacity for some apps I commonly use on daily basis.
I'm not sure if this PR will be found useful or not.

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

@rishav12s
Copy link
Contributor

lol add these to your userprefs.conf thats the purpose of it

this type of pr wont be accepted

this is still prasanth's dotfiles so all the app/package choices will be according to him

@Kai-Johnstone
Copy link

afaik he disappeared off the face of the earth so now its mainly kRHYME7/Khing that mages it. we really should just set the opacity to 80 for everything lol

also can we add the class "org.qbittorrent.qBittorrent" pls

@rishav12s
Copy link
Contributor

do you see @kRHYME7 merging any unnecessary prs ?

this is extra stuff and not needed to be included here makes the .confs more bloated

if you want your custom choice of apps u may do so in userprefs.conf or make a fork and maintain it there (that's purpose of sourcing that file)

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Nov 4, 2024

Sorry I can't merge this for now. As users can just
windowsrulev2 = opacity 0.95 override 0.8 override 1 override,class:^(.*)$ this should work globally

then for subsequent overrides they can just explicitly use
windowsrulev2 = opacity 0.95 override 0.8 override 1 override ,class:^(kitty*)$

I honestly want to have the overrides keyword as a convention to avoid confusion across sourced files.

However, I think I can accept PRs about the defaults window behavior e.g float. As long as the application is essential e.g xdg-desktop-portals.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Nov 4, 2024

Sidenote it's fine to leave this PRs Open so that someone might actually need the config, then they can use it. This should serve as an entry point to your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants