Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Upgrade dependencies + support several icons + config mgmt #45

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

Resousse
Copy link
Contributor

  • Upgrade of dependencies including RobotGo v1
  • Adding of 3 more icons for the systray, linked to Change icon feature #41
  • Keep icon choice in a config file

This doesn't work as is, as it's blocked by this PR : prashantgupta24/activity-tracker#28
Once the linked PR will be merged and transformed into a new release/tag, the go.mod & go.sum file of this PR would require an update.

@Resousse
Copy link
Contributor Author

Hello @prashantgupta24 , this PR is not ready to be merged, but this one can be merged (and blocks this one): prashantgupta24/activity-tracker#28

cmd/main.go Outdated Show resolved Hide resolved
@prashantgupta24
Copy link
Owner

@Resousse thanks so much for this PR!

@prashantgupta24
Copy link
Owner

prashantgupta24 commented Oct 13, 2023

@Resousse feel free to update the go.sum file with the latest changes

Edit: I didn't realize I can push to your branch, updated go.sum

@prashantgupta24 prashantgupta24 changed the title Draft : Upgrade dependencies versions & support several icons ♻️ Upgrade dependencies + support several icons + config mgmt Oct 13, 2023
Copy link
Owner

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me!

@prashantgupta24 prashantgupta24 merged commit 1ca953d into prashantgupta24:master Oct 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants