New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes for comments during JOSS reviews #39

Merged

prashjha merged 4 commits into main from fix-joss

Feb 7, 2025

Owner

prashjha commented Feb 7, 2025

Fixes #35 #36

Partially fixes #37

Proposed Changes

update example files. To avoid keeping two separate example scripts, one for test and other for example, we now have examples copied from test/test_data/peridem folder with minor changes in time steps and number of outputs.
update README.md and remove hyperlinks in section headings.

prashjha added 4 commits

February 5, 2025 20:37


          JOSS review: clean-up, remove unused files

630b701


          JOSS review: clean-up, update example files from test/test_data/peridem

ad056cf


          JOSS review: finalize examples

6d94357


          update README file

182f6e4

prashjha merged commit 8599859 into main

3 checks passed

prashjha mentioned this pull request

More fixes for comments during JOSS reviews #40

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet