Issue 198: Fixes to allow running in Flink examples in SDP #199
Conversation
There was a problem hiding this comment.
I believe none of the samples as of now are supporting running with secure Pravega cluster. Moreover, the change that we have here is specific to publishing to Maven repo that Nautilus exposes. Should we target the PR against nautilus-samples repo?
cc @fpj
|
I believe it would be a lot of unnecessary work to maintain a separate repo for Nautilus-specific samples. As you can see this in PR, the main difference is the inclusion of the pravega credentials jar file which is controlled by a Gradle property and off by default. There's also the Maven publish to Nautilus but that is only used when specifically called to publish. Prior to this change, publish was not available. |
|
@claudiofahey due to issues we had in previous releases merging |
- Added Pravega credentials dependency to all projects - Flink JAR can now be published to Nautilus Maven repo. - Hadoop examples can now be run without Hadoop installed. - Spark examples can now be run without Spark installed. Signed-off-by: Claudio Fahey <[email protected]>
Signed-off-by: Claudio Fahey <[email protected]>
claudiofahey
force-pushed
the
nautilus-sdk-desktop
branch
from
35f1363 to
bd1b56e
Compare
|
This PR is ready for re-review. |
claudiofahey
changed the title
claudiofahey
requested review from
RaulGracia and
crazyzhou
and removed request for
fpj and
vijikarthi
Signed-off-by: Claudio Fahey [email protected]