Skip to content

Fix for issue #1343#1345

Open
afdev82 wants to merge 3 commits into
prawnpdf:masterfrom
adnotam:iss1343
Open

Fix for issue #1343#1345
afdev82 wants to merge 3 commits into
prawnpdf:masterfrom
adnotam:iss1343

Conversation

@afdev82

@afdev82 afdev82 commented Mar 19, 2024

Copy link
Copy Markdown

Fallback to 0.0 in case of no gutter

@andreavocado andreavocado left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are specs missing when options is empty or options[:*gutter] is nil.

Comment thread lib/prawn/grid.rb Outdated
Comment thread lib/prawn/grid.rb Outdated
Comment thread lib/prawn/grid.rb Outdated
@afdev82

afdev82 commented Apr 12, 2024

Copy link
Copy Markdown
Author

Yes, then I will add the specs.

Prefer fetch for default value

Co-authored-by: André Jährling <85166619+andreavocado@users.noreply.github.com>
@afdev82

afdev82 commented Apr 30, 2024

Copy link
Copy Markdown
Author

I have added a simple test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants