Skip to content

Commit

Permalink
Stop spinner during installation (#849)
Browse files Browse the repository at this point in the history
This allows npm and yarn to print their output to the cli.
Previously warnings and errors would be swallowed by the spinner
  • Loading branch information
marvinhagemeister authored and ForsakenHarmony committed Jul 25, 2019
1 parent 19b7e2c commit b835770
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/cli/lib/commands/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ module.exports = async function(repo, dest, argv) {
// await fs.copyFile(serviceWorkerSrc, join(resolve(cwd, dest), 'src', 'sw.js'));

if (argv.install) {
spinner.text = 'Installing dependencies';
spinner.text = 'Installing dependencies:\n';
spinner.stopAndPersist();
await install(target, isYarn);
}

Expand Down

0 comments on commit b835770

Please sign in to comment.