Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Regex to sets #398

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: Regex to sets #398

wants to merge 3 commits into from

Conversation

rschristian
Copy link
Member

Might be marginally faster? Probably easier to maintain at the very least -- easier to tell what properties are being replaced and which aren't.

I did this by comparing against Preact's types, mostly, with a few corrections needed for the SVG types.

Copy link

changeset-bot bot commented Sep 22, 2024

⚠️ No Changeset found

Latest commit: c12a3b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

SVG_CAMEL_CASE,
SVG_KEBAB_CASE,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed for consistency.

HTML_LOWER_CASE is converting camel-cased names to lower-cased, therefore SVG_CAMEL_CASE stands out as it's converting camel-cased names to kebab-cased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant