Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix test assertion #401

Merged
merged 1 commit into from
Oct 20, 2024
Merged

chore: fix test assertion #401

merged 1 commit into from
Oct 20, 2024

Conversation

marvinhagemeister
Copy link
Member

Randomly noticed an incorrect test assertion while looking through our tests. When you pass a regex to .contain() in chai it will cast it to a string and the rendered output does indeed not contain the string /\s/.

It should've been .match() instead. And because there is a space between an element name and an attribute, that needs to be removed too.

Copy link

changeset-bot bot commented Oct 20, 2024

⚠️ No Changeset found

Latest commit: b25154a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marvinhagemeister marvinhagemeister merged commit 77595a1 into main Oct 20, 2024
1 check passed
@marvinhagemeister marvinhagemeister deleted the fix-test-assertion branch October 20, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants