Add support for trackSignals comments on object property assignment

packages/react-transform/src/index.ts

@@ -97,13 +97,15 @@ function isOptedIntoSignalTracking(path: NodePath | null): boolean {
 		case "FunctionDeclaration":
 		case "VariableDeclarator":
 		case "VariableDeclaration":
+		case "AssignmentExpression":
 			return (
 				hasLeadingOptInComment(path) ||
 				isOptedIntoSignalTracking(path.parentPath)
 			);
 		case "ExportDefaultDeclaration":
 		case "ExportNamedDeclaration":
 		case "ObjectProperty":
+		case "ExpressionStatement":
 			return hasLeadingOptInComment(path);
 		default:
 			return false;
@@ -119,13 +121,15 @@ function isOptedOutOfSignalTracking(path: NodePath | null): boolean {
 		case "FunctionDeclaration":
 		case "VariableDeclarator":
 		case "VariableDeclaration":
+		case "AssignmentExpression":
 			return (
 				hasLeadingOptOutComment(path) ||
 				isOptedOutOfSignalTracking(path.parentPath)
 			);
 		case "ExportDefaultDeclaration":
 		case "ExportNamedDeclaration":
 		case "ObjectProperty":
+		case "ExpressionStatement":
 			return hasLeadingOptOutComment(path);
 		default:
 			return false;

packages/react-transform/test/node/index.test.tsx

@@ -511,6 +511,46 @@ describe("React Signals Babel Transform", () => {
 
 			runTest(inputCode, expectedOutput, { mode: "manual" });
 		});
+
+		it("transforms functions assigned to object properties with leading opt-in JSDoc comments", () => {
+			const inputCode = `
+				var obj = {};
+				/** @trackSignals */
+				obj.a = () => {};
+				/** @trackSignals */
+				obj.b = function () {};
+				/** @trackSignals */
+				obj["c"] = function () {};
+			`;
+
+			const expectedOutput = `
+				import { useSignals as _useSignals } from "@preact/signals-react/runtime";
+				var obj = {};
+				/** @trackSignals */
+				obj.a = () => {
+					var _effect = _useSignals();
+					try {} finally {
+						_effect.f();
+					}
+				};
+				/** @trackSignals */
+				obj.b = function () {
+					var _effect2 = _useSignals();
+					try {} finally {
+						_effect2.f();
+					}
+				};
+				/** @trackSignals */
+				obj["c"] = function () {
+					var _effect3 = _useSignals();
+					try {} finally {
+						_effect3.f();
+					}
+				};
+			`;
+
+			runTest(inputCode, expectedOutput, { mode: "manual" });
+		});
 	});
 
 	describe("auto mode opt-out transformations", () => {
@@ -673,6 +713,43 @@ describe("React Signals Babel Transform", () => {
 
 			runTest(inputCode, expectedOutput, { mode: "auto" });
 		});
+
+		it("skips transforming functions declared as object properties with leading opt-out JSDoc comments", () => {
+			const inputCode = `
+				var obj = {
+					/** @noTrackSignals */
+					a: () => {},
+					/** @noTrackSignals */
+					b: function () {},
+					/** @noTrackSignals */
+					c: function c() {}
+				};
+			`;
+
+			const expectedOutput = inputCode;
+
+			runTest(inputCode, expectedOutput, { mode: "auto" });
+		});
+
+		it("skips transforming functions assigned to object properties with leading opt-out JSDoc comments", () => {
+			const inputCode = `
+				var obj = {};
+				/** @noTrackSignals */
+				obj.a = () => <div />;
+				/** @noTrackSignals */
+				obj.b = function () {
+					return <div />;
+				};
+				/** @noTrackSignals */
+				obj["c"] = function () {
+					return <div />;
+				};
+			`;
+
+			const expectedOutput = inputCode;
+
+			runTest(inputCode, expectedOutput, { mode: "auto" });
+		});
 	});
 
 	describe("auto mode no transformations", () => {