Skip to content

Commit

Permalink
Add test for unwrapping signals passed as DOM prop in React (#363)
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewiggins committed May 15, 2023
1 parent 26f6526 commit d38fd8a
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions packages/react/test/browser/updates.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,24 @@ describe("@preact/signals-react updating", () => {
expect(scratch.textContent).to.equal("bar");
});

it("should subscribe to signals passed as props to DOM elements", async () => {
const className = signal("foo");
function App() {
// @ts-expect-error React types don't allow signals on DOM elements :/
return <div className={className} />;
}

await render(<App />);

expect(scratch.innerHTML).to.equal('<div class="foo"></div>');

await act(() => {
className.value = "bar";
});

expect(scratch.innerHTML).to.equal('<div class="bar"></div>');
});

it("should activate signal accessed in render", async () => {
const sig = signal(null);

Expand Down

0 comments on commit d38fd8a

Please sign in to comment.