Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix React adapter in SSR and when rerendering #355

Merged
merged 26 commits into from
Apr 24, 2023
Merged

Fix React adapter in SSR and when rerendering #355

merged 26 commits into from
Apr 24, 2023

Commits on Apr 21, 2023

  1. Add reproduction of sync component rerenders causing failures

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7f34c3b View commit details
    Browse the repository at this point in the history

  2. Temporarily skip the renderToStaticMarkup test for now. Will address … 

    …later
    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    828e701 View commit details
    Browse the repository at this point in the history

  3. Update test to call unmount to do actual React unmount

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    68d292b View commit details
    Browse the repository at this point in the history

  4. Update component entering check to work for react 18 prod bundle

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    77d7298 View commit details
    Browse the repository at this point in the history

  5. Update logic to explicitly discover rerender dispatcher

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    6cd9ccf View commit details
    Browse the repository at this point in the history

  6. Ignore timeout errors logged to console

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    2261447 View commit details
    Browse the repository at this point in the history

  7. Explicitly skip over transitions to and from development warning disp… 

    …atchers
    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    1a4e5e6 View commit details
    Browse the repository at this point in the history

  8. Attempt to fixing spuriously failing test involving cleanup effects b… 

    …y waiting until next frame to return from our fake act method
    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    028667d View commit details
    Browse the repository at this point in the history

  9. Add state machine as a comment and a TODO to update the old comment

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    32bdd27 View commit details
    Browse the repository at this point in the history

  10. Reenable static markup test

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    b101fa2 View commit details
    Browse the repository at this point in the history

  11. Move current react tests to browser folder

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f3df910 View commit details
    Browse the repository at this point in the history

  12. Add initial renderToStaticMarkup test with basic test infra

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    83ec845 View commit details
    Browse the repository at this point in the history

  13. Simplify NodeJS babel config since Node tests always run against buil… 

    …d output
    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    d3ea8e5 View commit details
    Browse the repository at this point in the history

  14. Add some more comments and investigations to look at

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    83e5a06 View commit details
    Browse the repository at this point in the history

  15. Properly detect server render dispatchers and do nothing

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    6d0651f View commit details
    Browse the repository at this point in the history

  16. Add basic SSR tests and share with browser tests

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    693b84d View commit details
    Browse the repository at this point in the history

  17. Improve rerender dispatcher detection

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    30b54ee View commit details
    Browse the repository at this point in the history

  18. Ignore other useless console errors

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9e6a4e0 View commit details
    Browse the repository at this point in the history

  19. Add more tests for rerendering

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    8a8c0d3 View commit details
    Browse the repository at this point in the history

  20. Run server tests on minify

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    792ad2e View commit details
    Browse the repository at this point in the history

  21. Add test for state-less hooked component

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    1e2f9f3 View commit details
    Browse the repository at this point in the history

  22. Update implementation comments

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7c1e4a6 View commit details
    Browse the repository at this point in the history

  23. Add test for changing signal during mount

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    5a37285 View commit details
    Browse the repository at this point in the history

  24. Update comment on state machine

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    492bddd View commit details
    Browse the repository at this point in the history

  25. Add changeset

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    21c8ee9 View commit details
    Browse the repository at this point in the history

  26. Update CI to build then test

    @andrewiggins
    andrewiggins committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    eba0b93 View commit details
    Browse the repository at this point in the history