Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about tradeoffs in current React integration #358

Merged
merged 1 commit into from
May 1, 2023

Conversation

andrewiggins
Copy link
Member

In parallel, I'm also gonna explore some alternate implementations that offers different tradeoffs so teams can choose the best option for their project.

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2023

🦋 Changeset detected

Latest commit: 08ed3a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 28, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 08ed3a0
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/644c387b8649800008a15817
😎 Deploy Preview https://deploy-preview-358--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

Size Change: 0 B

Total Size: 68.9 kB

ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.5 kB
docs/dist/assets/index.********.js 835 B
docs/dist/assets/jsxRuntime.module.********.js 282 B
docs/dist/assets/preact.module.********.js 4 kB
docs/dist/assets/signals-core.module.********.js 1.42 kB
docs/dist/assets/signals.module.********.js 1.97 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.35 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 237 B
packages/core/dist/signals-core.js 1.48 kB
packages/core/dist/signals-core.mjs 1.5 kB
packages/preact/dist/signals.js 1.2 kB
packages/preact/dist/signals.mjs 1.15 kB
packages/react/dist/signals.js 1.21 kB
packages/react/dist/signals.mjs 1.15 kB

compressed-size-action

@developit developit merged commit d0c74e4 into main May 1, 2023
@developit developit deleted the react-integration-note branch May 1, 2023 14:09
@github-actions github-actions bot mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants