Add type checking to CI #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9a394fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Size Change: 0 B Total Size: 68.9 kB ℹ️ View Unchanged
|
rschristian
approved these changes
May 1, 2023
andrewiggins
force-pushed
the
linting-and-type-checking
branch
from
93ac120
to
7dba103
Compare
andrewiggins
force-pushed
the
linting-and-type-checking
branch
from
7dba103
to
9a394fa
Compare
JoviDeCroock
approved these changes
May 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up tsconfig.json and source files so we can start running type checking in CI. I had to change the types of Signals core Effect callback function from returning
voidtounknownto support a common test (and possible user pattern) of doing a simple inlineeffect(() => signal.value++);or something like this. We previously required those functions to not return. This change loosens that requirement to the return an unknown. Let me know what you think!I've left the docs folder as in and didn't address any errors in there.