-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests verifying the behavior of nested effects and computeds #371
Conversation
|
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -189,6 +189,70 @@ describe("@preact/signals", () => { | |||
rerender(); | |||
expect(spy).to.be.calledOnce; | |||
}); | |||
|
|||
it("should not subscribe to computed signals only created and not used", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@developit Does this test capture the behavior we've spoken about in some of our meetings re: creating and passing down computed values. Just figured I'd add a test to ensure the core integration libraries have the behavior we expect.
Size Change: 0 B Total Size: 68.9 kB ℹ️ View Unchanged
|
Specifically tests creating and passing computed between components