refactor: Remove non-functional package.json#exports.umd
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 878245c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Size Change: 0 B Total Size: 69.1 kB ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Jun 20, 2023
|
Can do! I should've mentioned this on that PR, but evidently forgot to. |
rschristian
force-pushed
the
refactor/exports.umd
branch
from
392e13f
to
878245c
Compare
andrewiggins
approved these changes
Jun 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all three of the packages,
package.json#exports.umdhas been referencing the incorrect path for the UMD bundles since release (should've beenx.min.js).However, seeing as how I can't see a single complaint relating to this, and I'm not aware of any tools that actually consume it (would love to know if there are tools that do), I elected to remove the entries. Saves us from making a breaking change in the future if we were to alter that entry in any way.