Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pnpm v8 #391

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Upgrade to pnpm v8 #391

merged 1 commit into from
Jul 23, 2023

Conversation

andrewiggins
Copy link
Member

@andrewiggins andrewiggins commented Jul 20, 2023

It appears some of our Netlify builds (e.g. in PR #375) are failing due to pnpm version mismatch. This PR upgrades our version to the latest (v8) to fix them.

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023

⚠️ No Changeset found

Latest commit: 5db8414

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 5db8414
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/64b87c0dbd451100074ef62d
😎 Deploy Preview https://deploy-preview-391--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewiggins
Copy link
Member Author

Note - compressed-size action will fail cuz it checks out the previous main branch which has the old lockfile and isn't compatible with the new lock file

@JoviDeCroock JoviDeCroock merged commit 3b32463 into main Jul 23, 2023
6 of 7 checks passed
@JoviDeCroock JoviDeCroock deleted the upgrade-pnpm branch July 23, 2023 07:27
@JoviDeCroock
Copy link
Member

Merged it as it fixes our workflows for other PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants