-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add unique identifier for signals #405
Conversation
🦋 Changeset detectedLatest commit: 87b589b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +91 B (0%) Total Size: 78.1 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea. Would make checking for signals a bit easier 👍
efd75d1
to
87b589b
Compare
@marvinhagemeister do you agree with |
@JoviDeCroock brand is fine. Fits in line with the whole "branded types" idea |
fixes #402
This allows for multiple versions of signals to be in a bundle and still be properly identified as signals.