Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add unique identifier for signals #405

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Conversation

JoviDeCroock
Copy link
Member

fixes #402

This allows for multiple versions of signals to be in a bundle and still be properly identified as signals.

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 87b589b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 87b589b
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/64f597e88b68e0000840c577
😎 Deploy Preview https://deploy-preview-405--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Size Change: +91 B (0%)

Total Size: 78.1 kB

Filename Size Change
docs/dist/assets/client.********.js 46.7 kB -5 B (0%)
docs/dist/assets/index.********.js 833 B -2 B (0%)
docs/dist/assets/signals-core.module.********.js 1.46 kB +31 B (+2%)
docs/dist/assets/signals.module.********.js 2.02 kB +1 B (0%)
docs/dist/demos-********.js 3.35 kB +1 B (0%)
packages/core/dist/signals-core.js 1.54 kB +35 B (+2%)
packages/core/dist/signals-core.mjs 1.56 kB +30 B (+2%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/jsxRuntime.module.********.js 281 B
docs/dist/assets/preact.module.********.js 4.02 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 238 B
packages/preact/dist/signals.js 1.27 kB
packages/preact/dist/signals.mjs 1.22 kB
packages/react-transform/dist/signals-*********.js 2.79 kB
packages/react-transform/dist/signals-transform.mjs 2.66 kB
packages/react-transform/dist/signals-transform.umd.js 2.91 kB
packages/react/dist/signals.js 1.35 kB
packages/react/dist/signals.mjs 1.29 kB

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Would make checking for signals a bit easier 👍

@JoviDeCroock
Copy link
Member Author

@marvinhagemeister do you agree with brand as the property name, had to change it due to type conflicting with ReactElement

@marvinhagemeister
Copy link
Member

@JoviDeCroock brand is fine. Fits in line with the whole "branded types" idea

@JoviDeCroock JoviDeCroock merged commit 9355d96 into main Sep 4, 2023
6 checks passed
@JoviDeCroock JoviDeCroock deleted the signal-identifier branch September 4, 2023 08:46
@github-actions github-actions bot mentioned this pull request Sep 4, 2023
JoviDeCroock added a commit that referenced this pull request Sep 5, 2023
JoviDeCroock added a commit that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect a signal without tightly binding to a version of the library
2 participants