Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register newly inserted import statement as a declaration in Babel scope #406

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

andrewiggins
Copy link
Member

When inserting a new import statement, we need to register it with Babel's scope tracking so future usages of the import are properly tracked to this declaration.

I've also removed CJS support currently since we don't have any tests for it and I'm uncertain if the maintenance burden if worth it. Open to suggestions.

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 457fc45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-react-transform Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 457fc45
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/64f25a9f5e351a000809883c
😎 Deploy Preview https://deploy-preview-406--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Size Change: +1.59 kB (+2%)

Total Size: 79.6 kB

Filename Size Change
packages/react-transform/dist/signals-*********.js 3.51 kB +720 B (+26%) 🚨
packages/react-transform/dist/signals-transform.mjs 2.82 kB +160 B (+6%) 🔍
packages/react-transform/dist/signals-transform.umd.js 3.63 kB +712 B (+24%) 🚨
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.7 kB
docs/dist/assets/index.********.js 835 B
docs/dist/assets/jsxRuntime.module.********.js 281 B
docs/dist/assets/preact.module.********.js 4.02 kB
docs/dist/assets/signals-core.module.********.js 1.43 kB
docs/dist/assets/signals.module.********.js 2.02 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.35 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 238 B
packages/core/dist/signals-core.js 1.5 kB
packages/core/dist/signals-core.mjs 1.53 kB
packages/preact/dist/signals.js 1.27 kB
packages/preact/dist/signals.mjs 1.22 kB
packages/react/dist/signals.js 1.35 kB
packages/react/dist/signals.mjs 1.29 kB

compressed-size-action

@andrewiggins andrewiggins merged commit 71caaad into main Sep 5, 2023
7 checks passed
@andrewiggins andrewiggins deleted the scope-fix branch September 5, 2023 21:05
@github-actions github-actions bot mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants