-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SignalValue component when using react-transform #422
Conversation
|
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +1.07 kB (+1%) Total Size: 80.8 kB
ℹ️ View Unchanged
|
622e18e
to
0af2c4e
Compare
0af2c4e
to
75a34c9
Compare
53d9674
to
9a7652c
Compare
Abandoning this for the moment. May revisit later after resolving other issues first |
When using the react-transform, components aren't automatically tracked for signal usage. So the SignalValue component isn't reactive to signal changes. This PR manually codes the SignalValue to use
useSignals
to track signal usage regardless of the implementation.Related #412