Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture expected behavior of passing signals through context #425

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

andrewiggins
Copy link
Member

Adding a test to capture expected behavior of passing a model containing signals through context, to ensure as I make changes to the react adapter, etc. I don't break this pattern

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: dcdc941

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit dcdc941
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/651e030df660ea0008773a0f
😎 Deploy Preview https://deploy-preview-425--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Size Change: 0 B

Total Size: 79.7 kB

ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.7 kB
docs/dist/assets/index.********.js 833 B
docs/dist/assets/jsxRuntime.module.********.js 281 B
docs/dist/assets/preact.module.********.js 4.02 kB
docs/dist/assets/signals-core.module.********.js 1.46 kB
docs/dist/assets/signals.module.********.js 2.02 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.35 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 238 B
packages/core/dist/signals-core.js 1.54 kB
packages/core/dist/signals-core.mjs 1.56 kB
packages/preact/dist/signals.js 1.27 kB
packages/preact/dist/signals.mjs 1.22 kB
packages/react-transform/dist/signals-*********.js 3.52 kB
packages/react-transform/dist/signals-transform.mjs 2.84 kB
packages/react-transform/dist/signals-transform.umd.js 3.64 kB
packages/react/dist/signals.js 1.35 kB
packages/react/dist/signals.mjs 1.29 kB

compressed-size-action

@andrewiggins andrewiggins merged commit de68f7c into main Oct 5, 2023
5 checks passed
@andrewiggins andrewiggins deleted the signals-computed-context branch October 5, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants